Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat [#107] 타임테이블 페스티벌 삭제 API 구현 #108

Merged
merged 1 commit into from
Jan 18, 2025
Merged

feat [#107] 타임테이블 페스티벌 삭제 API 구현 #108

merged 1 commit into from
Jan 18, 2025

Conversation

ch1hyun
Copy link
Collaborator

@ch1hyun ch1hyun commented Jan 18, 2025

✨ Issue Number ✨

closes #107

✨ To-do ✨

  • existsById 반환 값 boolean으로 변경
  • 타임테이블 페스티벌 삭제 API 구현

✨ Description ✨  

image

파사드 계층에서 값의 존재 여부에 따라 로직을 구성하기 위해 서비스 계층에서 existsById 반환 값을 boolean으로 수정했습니다. (확장성 고려)
타임테이블 페스티벌 삭제 API를 구현했습니다.

@ch1hyun ch1hyun added the ✨ Feature 기능 개발 label Jan 18, 2025
@ch1hyun ch1hyun self-assigned this Jan 18, 2025
Ivoryeee
Ivoryeee approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@Ivoryeee Ivoryeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 코드로 보니 existsById 부분에 예외가 발생하지 않도록 수정하신 이유를 잘 알겠네요! 너무 좋습니다 구웃 수고하셨어용

@ch1hyun ch1hyun merged commit cc18958 into develop Jan 18, 2025
2 checks passed
@ch1hyun ch1hyun deleted the feat#107/removeFestival branch January 18, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivoryeee Ivoryeee Ivoryeee approved these changes

Assignees

@ch1hyun ch1hyun

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 타임테이블 페스티벌 삭제 API 구현
2 participants
@ch1hyun @Ivoryeee